chore(deps): update dependency pyenv/pyenv to v2.6.31#35
Conversation
65ab76f to
f56801b
Compare
f56801b to
f1965be
Compare
f1965be to
00d9235
Compare
00d9235 to
33c16a3
Compare
📝 WalkthroughWalkthroughThe Dockerfile is updated to use pyenv version ChangesPyenv Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Around line 17-18: The PYENV version token ARG PYENV_VERSION is being set
without the leading "v" (e.g., 2.6.31) but later the repository is cloned with
git clone --branch "${PYENV_VERSION}" which expects tags like v2.6.31; update
the code so the tag matches Renovate output — either remove the extractVersion
from the renovate config so PYENV_VERSION keeps the "v" prefix, or (simpler)
change the clone to use the "v" prefix when checking out (e.g., use git clone
--branch "v${PYENV_VERSION}" or otherwise prepend "v" to PYENV_VERSION before
using it); make the fix where ARG PYENV_VERSION is defined and where git clone
--branch "${PYENV_VERSION}" is called to ensure consistent tag format.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| # renovate: datasource=github-tags depName=pyenv/pyenv extractVersion=^v(?<version>\d+\.\d+\.\d+)$ | ||
| ARG PYENV_VERSION=v2.6.27 | ||
| ARG PYENV_VERSION=2.6.31 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check pyenv repository tag format to confirm whether tags use 'v' prefix
# Fetch recent tags from pyenv/pyenv repository
echo "=== Recent pyenv tags ==="
gh api repos/pyenv/pyenv/tags --jq '.[0:10] | .[] | .name' 2>/dev/null || \
curl -s https://api.github.com/repos/pyenv/pyenv/tags | jq -r '.[0:10] | .[] | .name'
# Check if tag v2.6.31 exists
echo -e "\n=== Checking for v2.6.31 tag ==="
gh api repos/pyenv/pyenv/git/ref/tags/v2.6.31 --jq '.ref' 2>/dev/null || \
curl -s https://api.github.com/repos/pyenv/pyenv/git/ref/tags/v2.6.31 | jq -r '.ref // "Tag not found"'
# Check if tag 2.6.31 (without v) exists
echo -e "\n=== Checking for 2.6.31 tag (without v prefix) ==="
gh api repos/pyenv/pyenv/git/ref/tags/2.6.31 --jq '.ref' 2>/dev/null || \
curl -s https://api.github.com/repos/pyenv/pyenv/git/ref/tags/2.6.31 | jq -r '.ref // "Tag not found"'Repository: data219/opencode-docker
Length of output: 425
🏁 Script executed:
sed -n '240,245p' DockerfileRepository: data219/opencode-docker
Length of output: 362
Version format mismatch will break the git clone command.
The renovate configuration extracts the version without the 'v' prefix (line 17: extractVersion=^v(?<version>\d+\.\d+\.\d+)$), setting PYENV_VERSION to 2.6.31. However, line 242 uses git clone --branch "${PYENV_VERSION}" which attempts to checkout tag 2.6.31. The pyenv repository uses tags with the 'v' prefix (e.g., v2.6.31), so the git clone will fail with "reference not found."
🔧 Proposed fixes
Option 1 (Recommended): Remove extractVersion from renovate config to preserve the 'v' prefix
-# renovate: datasource=github-tags depName=pyenv/pyenv extractVersion=^v(?<version>\d+\.\d+\.\d+)$
+# renovate: datasource=github-tags depName=pyenv/pyenv
-ARG PYENV_VERSION=2.6.31
+ARG PYENV_VERSION=v2.6.31Option 2: Prepend 'v' prefix in the git clone command
-RUN git clone --branch "${PYENV_VERSION}" --depth 1 https://github.com/pyenv/pyenv.git /home/opencode/.pyenv \
+RUN git clone --branch "v${PYENV_VERSION}" --depth 1 https://github.com/pyenv/pyenv.git /home/opencode/.pyenv \As per coding guidelines, prefer version formats in Dockerfile that can be mapped back into download URLs without extra manual edits when Renovate proposes upgrades.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # renovate: datasource=github-tags depName=pyenv/pyenv extractVersion=^v(?<version>\d+\.\d+\.\d+)$ | |
| ARG PYENV_VERSION=v2.6.27 | |
| ARG PYENV_VERSION=2.6.31 | |
| # renovate: datasource=github-tags depName=pyenv/pyenv | |
| ARG PYENV_VERSION=v2.6.31 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Dockerfile` around lines 17 - 18, The PYENV version token ARG PYENV_VERSION
is being set without the leading "v" (e.g., 2.6.31) but later the repository is
cloned with git clone --branch "${PYENV_VERSION}" which expects tags like
v2.6.31; update the code so the tag matches Renovate output — either remove the
extractVersion from the renovate config so PYENV_VERSION keeps the "v" prefix,
or (simpler) change the clone to use the "v" prefix when checking out (e.g., use
git clone --branch "v${PYENV_VERSION}" or otherwise prepend "v" to PYENV_VERSION
before using it); make the fix where ARG PYENV_VERSION is defined and where git
clone --branch "${PYENV_VERSION}" is called to ensure consistent tag format.
This PR contains the following updates:
v2.6.27→2.6.31Release Notes
pyenv/pyenv (pyenv/pyenv)
v2.6.31Compare Source
v2.6.30Compare Source
v2.6.29Compare Source
v2.6.28Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit